Project

General

Profile

Bug #1991

Cache not cleared prevent location / org feature to show up

Added by Romain Vrignaud over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ohad Levy
Category:
Organizations and Locations
Target version:
1.1
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

When I switch on the location and org feature,
tmp files prevent the 2 features to show up.

Associated revisions

Revision 88824e07 (diff)
Added by Ohad Levy over 9 years ago

refs #1991 - Cache not cleared prevent location / org feature to show up

1. ensures settings cache is removed when app starts
we can't remove all cache, with Rails.cache.clear as that might lead to issues
with people using memcache with multiple foreman instances (e.g. we can clear
the progress bar cache while restarting another foreman instance).

The other alternative is to put a TTL on the settings, but I think this
option for this specific case makes more sense.

2. fixed the cache directory, from /tmp to /tmp/cache.

Revision 596d5f09 (diff)
Added by Joseph Magen over 9 years ago

fixes #1991 expire topbar cache on user when restart server

History

#1 Updated by Greg Sutcliffe over 9 years ago

Does it makes sense to clear cache when the Foreman process starts up? That would seem the easiest fix...

#2 Updated by Ohad Levy over 9 years ago

  • Assignee set to Greg Sutcliffe

yes!

#3 Updated by Sam Kottler over 9 years ago

  • Category set to Organizations and Locations
  • Status changed from New to Assigned
  • Assignee changed from Greg Sutcliffe to Sam Kottler

I'm going to work on this issue. Greg, if you have a patch written then feel free to reassign it to yourself.

#4 Updated by Greg Sutcliffe over 9 years ago

I do not. Enjoy :)

This should also fix an issue where the tests affect the production environment due to the cache not being properly cleared.

#5 Updated by Sam Kottler over 9 years ago

Excellent. Impending patch :-)

#6 Updated by Ohad Levy over 9 years ago

  • Status changed from Assigned to Ready For Testing
  • Assignee changed from Sam Kottler to Ohad Levy

#7 Updated by Ohad Levy over 9 years ago

  • Status changed from Ready For Testing to Assigned

on second thought, clearing the cache might not be ideal.

assuming we a memcache based cache + multiple foreman web frontends, one could clear the cache for another one, resulting with removing things like a host progress bar as well.

#8 Updated by Anonymous over 9 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF