Bug #2023
closed
Don't try to save os=nil in the fact importer
Description
(Was "Puppet run in Finish Template wipes Operating System field in DB")
It's possible to hit an edge case where the os field comes in as nil and we try to save a new OS with name=NULL to the DB, which fails validation. We should make that more defensive.
Files
Updated by Ohad Levy over 11 years ago
turn on sql debug and check the audit log too?
Updated by Greg Sutcliffe over 11 years ago
The audit log definitely shows the OS being wiped. I turned on fulldebug, but it was so noisy I couldn't see anything useful. I'll try and get a full log pastie up tomorrow.
Updated by Ohad Levy over 11 years ago
- Priority changed from Urgent to Normal
I can't reproduce this, WFM
Updated by Greg Sutcliffe over 11 years ago
Log attached. This seems easily repeatable for me - set a host to "Build" and run Puppet - OS disappears. You can see a rollback/audit happening in the report processing section.
Updated by Greg Sutcliffe over 11 years ago
- Subject changed from Puppet run in Finish Template wipes Operating System field in DB to Don't try to save os=nil in the fact importer
- Category changed from Host creation to Facts
- Assignee deleted (
Greg Sutcliffe) - Priority changed from Normal to Low
- Target version deleted (
1.1)
Updated by Ohad Levy over 11 years ago
- Target version set to 1.1
its not a nil os, rather a os with a nil name.
Updated by Ohad Levy over 11 years ago
- Status changed from New to Ready For Testing
- Assignee set to Ohad Levy
- Priority changed from Low to Normal
- % Done changed from 0 to 90
Updated by Ohad Levy over 11 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 90 to 100
Applied in changeset 10130849364f5184e3b0dcbae6cd6b4085ec1c84.