Bug #20272
Filtering user/user groups/capsules/compute profiles/compute resources with invalid field shows Internal Error
Description
Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1469148
Description of problem: We were trying to filter user/user groups/capsules/compute profiles/ compute resources. In filter, when we added field which was not present in list( any_string=any_string), it returned an error "Something went wrong" and log file had 500 Internal Server Error.
Version-Release number of selected component (if applicable): satellite 6.3.0 snap 6.0
How reproducible: always
Steps to Reproduce:
1. Navigate to Administer-> user/user groups/capsules/compute profiles/compute resources ( producible at any)
2. Filter as any_string=any_string
Actual results:
Shows the error as "Something went wrong" and the log file /var/log/foreman/production.log shows
Rendered common/500.html.erb within layouts/application (3.7ms)
2017-07-10 09:32:35 7d7c37e3 [app] [I] Rendered layouts/_application_content.html.erb (0.5ms)
2017-07-10 09:32:35 7d7c37e3 [app] [I] Rendered layouts/base.html.erb (2.6ms)
2017-07-10 09:32:35 7d7c37e3 [app] [I] Completed 500 Internal Server Error
Expected results: Error should be handled showing alert as "Field not recognised for searching" as happens in filtering hosts(Host -> All Hosts - > Filter ).
Additional info:
Associated revisions
Fixes #20272 - correctly rescue QueryNotSupported in production
When in production, the generic exception rescue shadows the
ScopedSearch::QueryNotSupported rescue method, preventing the correct
message being displayed on an invalid search.
History
#1
Updated by The Foreman Bot over 5 years ago
- Status changed from New to Ready For Testing
- Assignee set to Tomer Brisker
- Pull request https://github.com/theforeman/foreman/pull/4656 added
#2
Updated by Anonymous over 5 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 53b3c0e0c8c798f34864c0968e98dc052f029326.
#3
Updated by Marek Hulán over 5 years ago
- Legacy Backlogs Release (now unused) set to 276
Based on PR this lands in 1.15.3, so setting the release
Fixes #20272 - correctly rescue QueryNotSupported in production
When in production, the generic exception rescue shadows the
ScopedSearch::QueryNotSupported rescue method, preventing the correct
message being displayed on an invalid search.