Bug #20328
mounting react component twice doesn't work consistently
Description
When using the react mounter (https://github.com/theforeman/foreman/blob/develop/webpack/assets/javascripts/react_app/common/MountingService.js) and somehow (usually via ajax) mount a component into an existing div (that already have a react on it), the portion showed on the screen will differ based on how the top level mounted component is implemented (e.g. some will read the state from the store, others will reinit it etc).
I would suggest that since this is usually a side effect of using react via ajax (e.g. compute resource vm tab is reloaded because you selected a different org) we should default to clearing the react component div prior to remounting it.
Associated revisions
History
#1
Updated by The Foreman Bot about 5 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/4680 added
#2
Updated by Daniel Lobato Garcia about 5 years ago
- Legacy Backlogs Release (now unused) set to 240
#3
Updated by Ohad Levy about 5 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 9cfb8e311eaf266a883fb9127ace9447272b8d17.
fixes #20328 - ensure target div is always empty
this solves the problem when a div has already react component on it,
which gets reloaded via some ajax call.