Hammer CLI

Just for the record:
Setting parameters with set-parameter command works correctly and can be used as a workaround. It's only the update command that's broken.

During testing the PR I've noticed the format used is actually not valid. For --params option we support either comma separated list of key=value or JSON. For some reason we try to parse also the value if it is list which is causing problems here. The format used is mix of CSV and JSON which needs to be avoided.

My suggestion is either to use JSON (recomended for more complex params):

hammer -u username host update --name testserver.example.com --parameters '{"diskinfo3":[{"group": "apache", "pciid": 160, "fstype": "ext4", "mntopts": "", "owner": "root", "path": "/mount/point/1", "fmtopts": "", "scsiid": 1, "size": 75}, {"group": "apache", "pciid": 160, "fstype": "xfs", "mntopts": "", "owner": "apache", "path": "/mount/point/2", "fmtopts": "", "scsiid": 2, "size": 200}]}'

or comma separated list which needs proper quoting (I didn't tested the API can handle this particular case):

hammer -u username host update --name testserver.example.com --parameters diskinfo3=['{"group": "apache", "pciid": 160, "fstype": "ext4", "mntopts": "", "owner": "root", "path": "/mount/point/1", "fmtopts": "", "scsiid": 1, "size": 75}', '{"group": "apache", "pciid": 160, "fstype": "xfs", "mntopts": "", "owner": "apache", "path": "/mount/point/2", "fmtopts": "", "scsiid": 2, "size": 200}']

The comma separated list does not work properly and needs to be fixed. I'll keep this issue to track that.

This issue should be fixed by the fix for the related issue #26120. Closing