Project

General

Profile

Refactor #204

Remove activescaffold from the environments page

Added by Paul Kelly over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Associated revisions

Revision 5f6b2196 (diff)
Added by Paul Kelly over 9 years ago

Fixes #204 - Remove AS from environments page

Merged import facility in Environment and Puppetclass controllers

History

#1 Updated by Paul Kelly over 9 years ago

  • Category set to Web Interface
  • Status changed from New to Resolved
  • Assignee set to Paul Kelly
  • Branch set to refactor/204-environment-no-as

Rebased against develop@95131ca23a6b28e295be839964f9663b0e07c559
ActiveScaffold removed from the environment_controller
actionlinks rewritten as action => :index + a query string

Note that I had to change the puppetclass index method to use Puppetclass.searchlogic() rather than Puppetclass.search(). It is not clear why.

#2 Updated by Ohad Levy over 9 years ago

  • Status changed from Resolved to Assigned
  • Target version set to 0.1-5

I cant merge this as it uses the searchlogic, please remove the search bit and I'll commit it.

e.g. in puppetclass controller:
+ @puppetclasses = Puppetclass.searchlogic(params[:search]).paginate :page => params[:page], :per_page => 15

#3 Updated by Paul Kelly over 9 years ago

  • Status changed from Assigned to Resolved

Rebased against develop
Changed "searchlogic" to "search"
A future ticket should replace the puppetclass.search mechanism with the tabbed search approach

#4 Updated by Ohad Levy over 9 years ago

  • Status changed from Resolved to Assigned

looking at the latest branch, it includes an import functionality, which is identical to the puppetclass import, can we some how merge them?
this might avoid the need to change the import method in the Environment model.

#5 Updated by Paul Kelly over 9 years ago

  • Status changed from Assigned to Ready For Testing
  • % Done changed from 0 to 100

#6 Updated by Ohad Levy over 9 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF