Commands in plugins use "ID" and "Id" inconsistently
Commands in plugins use "ID" and "Id" inconsistently:"ID":
Hammer should be consistent with labeling IDs. What is the "correct" label is yet TBD.
#1 Updated by Tomáš Strachota almost 5 years ago
- Project changed from Hammer CLI to Katello
- Subject changed from repository info command has ID field instead of Id to Commands in plugins use "ID" and "Id" inconsistently
- Description updated (diff)
- Category set to Hammer
Thank you for reporting the issue. In fact, the problem is much larger than just the repository command. I briefly checked the situation and some plugins seem to be using "ID" (hammer-cli-katello, hammer-cli-foreman-discovery, hammer-cli-foreman-tasks, hammer-cli-foreman-docker) while some use "Id" (hammer-cli-foreman, hammer-cli-foreman-virt-who-configure, hammer-cli-foreman-openscap). It's really nearly 50:50. I haven't found any plugin that would use the labels inconsistently within it's boundaries.
We should definitely be consistent, but we must decide what is the correct label first. The first step is imho a discussion on a mailing list.
I've updated the subject and description of the bug so that it gives the whole picture. Feel free to update it with some additional info.