Project

General

Profile

Bug #20629

Commands in plugins use "ID" and "Id" inconsistently

Added by Ondřej Pražák about 2 years ago. Updated about 1 year ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
Hammer
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Commands in plugins use "ID" and "Id" inconsistently:

"ID":
  • hammer-cli-katello
  • hammer-cli-foreman-discovery
  • hammer-cli-foreman-tasks
  • hammer-cli-foreman-docker
"Id":
  • hammer-cli-foreman
  • hammer-cli-foreman-virt-who-configure
  • hammer-cli-foreman-openscap

Hammer should be consistent with labeling IDs. What is the "correct" label is yet TBD.

History

#1 Updated by Tomáš Strachota about 2 years ago

  • Project changed from Hammer CLI to Katello
  • Subject changed from repository info command has ID field instead of Id to Commands in plugins use "ID" and "Id" inconsistently
  • Description updated (diff)
  • Category set to Hammer

Thank you for reporting the issue. In fact, the problem is much larger than just the repository command. I briefly checked the situation and some plugins seem to be using "ID" (hammer-cli-katello, hammer-cli-foreman-discovery, hammer-cli-foreman-tasks, hammer-cli-foreman-docker) while some use "Id" (hammer-cli-foreman, hammer-cli-foreman-virt-who-configure, hammer-cli-foreman-openscap). It's really nearly 50:50. I haven't found any plugin that would use the labels inconsistently within it's boundaries.

We should definitely be consistent, but we must decide what is the correct label first. The first step is imho a discussion on a mailing list.

I've updated the subject and description of the bug so that it gives the whole picture. Feel free to update it with some additional info.

#2 Updated by Eric Helms almost 2 years ago

  • Legacy Backlogs Release (now unused) set to 114

Also available in: Atom PDF