Actions
Bug #20742
closedHost reports command is dysfunctional
Status:
Closed
Priority:
High
Assignee:
Category:
Reporting
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Description
hammer host reports allow specifying the host by either --id or --name. None of the methods actually work.
Using --name
Ends up with 400 error
> hammer host reports --name sandy-oberdorf.tstracho-laptop Error: 400 Bad Request
caused by:
[ INFO 2017-08-25 12:27:34 API] GET /api/reports [DEBUG 2017-08-25 12:27:34 API] Params: { :search => "name = \"sandy-oberdorf.tstracho-laptop\"" } [DEBUG 2017-08-25 12:27:34 API] Headers: { :params => { :search => "name = \"sandy-oberdorf.tstracho-laptop\"" } } [ERROR 2017-08-25 12:27:34 API] 400 Bad Request [DEBUG 2017-08-25 12:27:34 API] { "error" => { "message" => "Field 'name' not recognized for searching!", "class" => "ScopedSearch::QueryNotSupported" } }
Using --id
Returns empty list
hammer host reports --id 13 ---|------|-------------|---------|-----------|--------|------------------|---------|-------- ID | HOST | LAST REPORT | APPLIED | RESTARTED | FAILED | RESTART FAILURES | SKIPPED | PENDING ---|------|-------------|---------|-----------|--------|------------------|---------|--------
which is caused by wrong search condition:
[ INFO 2017-08-25 12:54:59 API] GET /api/reports [DEBUG 2017-08-25 12:54:59 API] Params: { "page" => 1, "per_page" => 1000, "id" => "13", "host_id" => "13" } [DEBUG 2017-08-25 12:54:59 API] Headers: { :params => { "page" => 1, "per_page" => 1000, "id" => "13", "host_id" => "13" } } [DEBUG 2017-08-25 12:54:59 API] Using authenticator: HammerCLIForeman::Api::SessionAuthenticatorWrapper [DEBUG 2017-08-25 12:54:59 API] Response: { "total" => 135, "subtotal" => 0, "page" => 1, "per_page" => 1000, "search" => " host = 13", "sort" => { "by" => nil, "order" => nil }, "results" => [] }
Note that searching by "host = <HOSTNAME>" would work as intended (tested in the UI).
The fix should be quite simple: modify the command to use "host = X" or "host.id = X" search query according to what parameters were used.
Updated by Tomáš Strachota over 7 years ago
- Related to Bug #14510: Hammer should use /config_reports rather than /reports added
Updated by Tomáš Strachota over 7 years ago
At the moment the command also uses an old api endpoint (tracked in http://projects.theforeman.org/issues/14510). It would be good to fix the two issues together.
Updated by Ondřej Pražák about 7 years ago
- Status changed from New to Assigned
- Assignee set to Ondřej Pražák
Updated by Ondřej Pražák about 7 years ago
- Related to Feature #21602: Add scoped_search on host id for reports added
Updated by The Foreman Bot about 7 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/hammer-cli-foreman/pull/339 added
Updated by The Foreman Bot about 7 years ago
- Pull request https://github.com/theforeman/hammer-cli-foreman/pull/340 added
Updated by Marek Hulán about 7 years ago
- Pull request deleted (
https://github.com/theforeman/hammer-cli-foreman/pull/339)
Updated by Martin Bacovsky about 7 years ago
- Assignee changed from Ondřej Pražák to Martin Bacovsky
- Target version set to 233
Updated by Martin Bacovsky about 7 years ago
- Translation missing: en.field_release set to 290
Updated by Martin Bacovsky about 7 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset hammer-cli-foreman|d9b0280b581f733151c238e66a641cbac57464e7.
Actions