Project

General

Profile

Bug #20890

SSH key validations should return better messages

Added by Tomáš Strachota about 3 years ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Users, Roles and Permissions
Target version:
Difficulty:
trivial
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Creating an ssh key with invalid format results in following two messages:

Key is invalid
Key is invalid

It's caused by ssh_key and format validators:
https://github.com/theforeman/foreman/blob/develop/app/models/ssh_key.rb#L23-L24

The error messages should contain more information:

Key is not a valid public ssh key.
Key must be in OpenSSH public key format.

Associated revisions

Revision 4a96211d (diff)
Added by Shira Maximov about 3 years ago

Fixes #20890 - changes SSH key validation messages

History

#1 Updated by Shira Maximov about 3 years ago

  • Status changed from New to Assigned
  • Assignee set to Shira Maximov

#2 Updated by The Foreman Bot about 3 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4834 added

#3 Updated by Marek Hulán about 3 years ago

  • Legacy Backlogs Release (now unused) set to 296

#4 Updated by Anonymous about 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Tomer Brisker 3 months ago

  • Category changed from 218 to Users, Roles and Permissions

Also available in: Atom PDF