Project

General

Profile

Bug #20925

katello-change-hostname should check exit codes of shell executions

Added by Evgeni Golov about 1 year ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tooling
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

currently, k-c-h does a lot `something in shell`, but never verifies the exit code and thus does not know if the execution actually succeeded.

I think it should verify that every execution returned 0 and abort the rename if that is not the case. ideally, the abort is coupled with a rollback, if that is feasible.

Associated revisions

Revision 685cad77 (diff)
Added by John Mitsch about 1 year ago

Fixes #20925 - k-change-hostname should check exit codes

History

#1 Updated by The Foreman Bot about 1 year ago

  • Status changed from New to Ready For Testing
  • Assignee set to John Mitsch
  • Pull request https://github.com/Katello/katello-packaging/pull/530 added

#2 Updated by John Mitsch about 1 year ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Brad Buckingham about 1 year ago

  • Target version set to 213

#4 Updated by Justin Sherrill about 1 year ago

  • Legacy Backlogs Release (now unused) set to 250

Also available in: Atom PDF