Project

General

Profile

Actions
Copy link

Bug #20925

closed

katello-change-hostname should check exit codes of shell executions

Added by Evgeni Golov about 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Mitsch
Category:
Tooling
Target version:
Katello 3.5.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/Katello/katello-packaging/pull/530
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

currently, k-c-h does a lot `something in shell`, but never verifies the exit code and thus does not know if the execution actually succeeded.

I think it should verify that every execution returned 0 and abort the rename if that is not the case. ideally, the abort is coupled with a rollback, if that is feasible.

Actions
Copy link
 #1

Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to John Mitsch
  • Pull request https://github.com/Katello/katello-packaging/pull/530 added
Actions
Copy link
 #2

Updated by John Mitsch about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Brad Buckingham about 7 years ago

  • Target version set to 213
Actions
Copy link
 #4

Updated by Justin Sherrill about 7 years ago

  • Translation missing: en.field_release set to 250
Actions
Copy link

Also available in: Atom PDF