Project

General

Profile

Refactor #20950

change 'uniq' to 'distinct' in ActiveRecord finders

Added by Michael Moll over 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Michael Moll
Category:
Rails
Target version:
1.17.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4857, https://github.com/theforeman/foreman/pull/4838
Fixed in Releases:
Found in Releases:

Related issues

Blocks Foreman - Tracker #15715: Rails 5.0 upgrade tasksResolved2016-07-18

Blocks Foreman - Tracker #20948: Rails 5.1 upgrade tasksClosed2017-09-16

Associated revisions

Revision ff1e9ffc (diff)
Added by Dominic Cleal over 2 years ago

Fixes #20950 - Use 'distinct' in AR finders

Revision 8762baa2 (diff)
Added by Michael Moll over 2 years ago

Refs #20950 - remove uniq in AR Finders whitelisting

History

#1 Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4838 added

#2 Updated by Michael Moll over 2 years ago

#3 Updated by Michael Moll over 2 years ago

#4 Updated by Dominic Cleal over 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by The Foreman Bot over 2 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4857 added

Also available in: Atom PDF