Bug #20970: Discovery via fact import is broken for rails 5 - Discovery - Foreman

Actions

Copy link

Bug #20970

closed

Discovery via fact import is broken for rails 5

Added by Tomer Brisker about 7 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Tomer Brisker

Category:

Discovery plugin

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman_discovery/pull/375

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Parsing facts fails in rails 5 due to the fact that the parameters are no longer a hash but rather `ActionController::Parameters`.
Full stacktrace:

ERF42-4717 [Foreman::Exception]: Invalid facts, must be a Hash
 | /home/tbrisker/gits/foreman_discovery/app/models/host/discovered.rb:37:in `import_host'
 | /home/tbrisker/gits/foreman_discovery/app/controllers/api/v2/discovered_hosts_controller.rb:100:in `block in facts'
 | /home/tbrisker/foreman/app/models/concerns/foreman/thread_session.rb:93:in `as'
 | /home/tbrisker/foreman/app/models/concerns/foreman/thread_session.rb:99:in `as_anonymous_admin'
 | /home/tbrisker/gits/foreman_discovery/app/controllers/api/v2/discovered_hosts_controller.rb:99:in `facts'
<snip>

Related issues 2 (0 open — 2 closed)