Project

General

Profile

Bug #21019

Rails 5 - ParamsParser middleware conversion

Added by Brad Buckingham about 4 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

As part of upgrading Katello to Rails 5, perform the necessary conversion to the ParamsParser middleware.

E.g.
2) ParamsParser middleware conversion. Discussion: https://github.com/Katello/katello/pull/6875#discussion_r127714637

Associated revisions

Revision ce312249 (diff)
Added by Justin Sherrill almost 4 years ago

Fixes #21019 - change content_type for specific actions

this commit removes the Params parser wrapper, replacing
it with middleware that modifies the content type for
certain requests to prevent json parsing of the content.

Rails 5 no longer uses the params parser middleware and
instead recommends you inherit from a different base
controller. However this would require massive refactoring
of Foreman controllers, and seems less than ideal

History

#1 Updated by Justin Sherrill about 4 years ago

  • Legacy Backlogs Release (now unused) set to 284

#2 Updated by The Foreman Bot about 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Justin Sherrill
  • Pull request https://github.com/Katello/katello/pull/6967 added

#3 Updated by Brad Buckingham almost 4 years ago

  • Target version changed from 217 to 225

#4 Updated by Justin Sherrill almost 4 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF