Project

General

Profile

Bug #21022

Bulk Actions dont handle confirmation properly

Added by Partha Aji almost 2 years ago. Updated 12 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Web UI
Target version:
Difficulty:
Triaged:
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Many of our bulk actions don't handle confirmations correctly. For example -
https://github.com/Katello/katello/blob/master/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/bulk/views/content-hosts-bulk-environment-modal.html#L18
has code that looks like

   <div bst-alert="info" ng-show="showConfirm">
      <span translate>
        Are you sure you want to assign the {{ table.numSelected }} content host(s) selected to {{ selected.contentView.name }} in {{ selected.environment.name }}?
      </span>
      <div>
        <button type="button" class="btn btn-default" ng-click="showConfirm = false; performAction()" translate>Yes</button>
        <button type="button" class="btn btn-default" ng-click="showConfirm = false;" translate>No</button>
      </div>
    </div>

Note there is no "ng-disabled" on 'Yes' when clicked. So we end up with issues where users will end up double clicking 'yes' because its waiting on an ajax call to happen. I see this in all of the views in https://github.com/Katello/katello/blob/master/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/bulk/views/

History

#1 Updated by Partha Aji almost 2 years ago

  • Category set to Web UI

#2 Updated by Walden Raines almost 2 years ago

  • Target version set to 219

#3 Updated by Justin Sherrill almost 2 years ago

  • Legacy Backlogs Release (now unused) set to 114

#4 Updated by Walden Raines about 1 year ago

  • Target version deleted (219)

Also available in: Atom PDF