Project

General

Profile

Refactor #21103

Replace 'false' AR callback results with explicit throw

Added by Anonymous over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Rails
Target version:
1.17.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/5065
Fixed in Releases:
Found in Releases:

Related issues

Related to Foreman - Tracker #15715: Rails 5.0 upgrade tasksResolved2016-07-18

Blocks Foreman - Tracker #20948: Rails 5.1 upgrade tasksClosed2017-09-16

Blocked by Foreman - Refactor #21084: Always use Rails 5.0, Drop Rails 4.2Closed2017-09-23

Associated revisions

Revision 66e83407 (diff)
Added by Dominic Cleal about 3 years ago

Fixes #21103 - Replace 'false' AR callback results with throw

History

#1 Updated by Anonymous over 3 years ago

#2 Updated by Anonymous over 3 years ago

#3 Updated by Anonymous over 3 years ago

#4 Updated by Daniel Lobato Garcia over 3 years ago

Where are these tasks coming from?

#5 Updated by Anonymous over 3 years ago

Daniel Lobato Garcia wrote:

Where are these tasks coming from?

https://github.com/theforeman/foreman/pull/4836

#6 Updated by The Foreman Bot about 3 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5065 added

#7 Updated by Dominic Cleal about 3 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF