Project

General

Profile

Bug #21112

Template editing form keeps registering select2 for host list in preview

Added by Ivan Necas over 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Templates
Target version:
Difficulty:
Triaged:
Bugzilla link:

Description

How to reproduce:

1. while watching the ajax requests being done to the server
2. open one template in two-pane
3. close and open different template
4. on every template open, one more request is done against /hosts/preview_host_collection


Related issues

Related to Foreman - Bug #12419: Template review host list limited by paginationClosed2015-11-08
Related to Foreman Remote Execution - Bug #21113: Require templates assets for job templatesReady For Testing2017-09-26

Associated revisions

Revision ba69e15c (diff)
Added by Tomer Brisker over 2 years ago

Fixes #21112 - Only initialize host preview once

Instead of adding the event every time the form is loaded, only do it
once when the editor is initialized.

History

#1 Updated by Ivan Necas over 2 years ago

  • Related to Bug #12419: Template review host list limited by pagination added

#2 Updated by Ivan Necas over 2 years ago

  • Subject changed from Template editing form keeps registering select2 for host list in preview to Template editing form keeps registering select2 for host list in preview
  • Category changed from TFTP to Templates

#3 Updated by Ivan Necas over 2 years ago

  • Status changed from New to Need more information
  • Assignee set to Ivan Necas

#4 Updated by The Foreman Bot over 2 years ago

  • Status changed from Need more information to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4876 added

#5 Updated by Ivan Necas over 2 years ago

  • Related to Bug #21113: Require templates assets for job templates added

#6 Updated by The Foreman Bot over 2 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4950 added

#7 Updated by Anonymous over 2 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#8 Updated by Marek Hulán over 2 years ago

  • Legacy Backlogs Release (now unused) set to 296

Also available in: Atom PDF