Project

General

Profile

Bug #21123

Fact import code does not work

Added by Lukas Zapletal about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
High
Assignee:
Shimon Shtein
Category:
Discovery plugin
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman_discovery/pull/381
Fixed in Releases:
Found in Releases:

Description

Due to refactoring in core:

ArgumentError: wrong number of arguments (given 2, expected 3)
    app/models/host/base.rb:174:in `populate_fields_from_facts'
    /home/lzap/work/foreman_discovery/app/models/host/discovered.rb:89:in `populate_fields_from_facts'
    app/models/host/base.rb:157:in `parse_facts'
    app/models/host/base.rb:146:in `import_facts'
    /home/lzap/work/foreman_discovery/app/models/host/discovered.rb:74:in `import_facts'
    /home/lzap/work/foreman_discovery/app/models/host/discovered.rb:66:in `import_host'

Related issues

Related to Foreman - Refactor #15409: Refactor (puppet) facts out of host classes.Closed

Associated revisions

Revision e2a51e6e (diff)
Added by Shimon Shtein about 3 years ago

Fixes #21123 - Changed populate_fields_from_facts signature

To reflect changes from #3649.

History

#1 Updated by Lukas Zapletal about 3 years ago

  • Related to Refactor #15409: Refactor (puppet) facts out of host classes. added

#2 Updated by The Foreman Bot about 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Shimon Shtein
  • Pull request https://github.com/theforeman/foreman_discovery/pull/381 added

#3 Updated by The Foreman Bot about 3 years ago

  • Pull request https://github.com/theforeman/foreman_discovery/pull/382 added

#4 Updated by Anonymous about 3 years ago

  • Pull request deleted (https://github.com/theforeman/foreman_discovery/pull/382)

#5 Updated by Shimon Shtein about 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF