Project

General

Profile

Bug #21127

Scap content file is printed into logs

Added by Ondřej Pražák over 1 year ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Difficulty:
Triaged:
No
Bugzilla link:
Team Backlog:
Marek
Fixed in Releases:
Found in Releases:

Description

Debug logger logs the response body. When scap content is downloaded via hammer, the response is the file itself, so the entire scap content file ends up in the logs. Because it only clutters the logs and does not contain any relevant debugging information, I think we should skip logging response body for download actions. This goes for tailoring files as well.

Steps to reproduce:
1) Download scap content using hammer/api

download-scap-content.png View download-scap-content.png 194 KB Ondřej Pražák, 09/27/2017 08:28 AM
Download scap content

Related issues

Related to Foreman - Bug #25482: Excessive logging of OpenScap report via Rails Ready For Testing

Associated revisions

Revision 725bf1a7 (diff)
Added by Ondřej Pražák 9 months ago

Fixes #21127 - Skip logging arf-report body

History

#1 Updated by Marek Hulán over 1 year ago

luckily we don't log debug messages in production, I agree we should just silence response body for download actions

#2 Updated by The Foreman Bot 10 months ago

  • Assignee set to Ondřej Pražák
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_openscap/pull/357 added

#3 Updated by Marek Hulán 9 months ago

  • Target version set to foreman_openscap 0.11.0
  • Fixed in Releases foreman_openscap 0.11.0 added

#4 Updated by Ondřej Pražák 9 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by Lukas Zapletal 7 months ago

  • Bugzilla link set to 1650543

#6 Updated by Lukas Zapletal 7 months ago

  • Bugzilla link deleted (1650543)

The BZ 1650543 is somehow related but a different bug actually.

#7 Updated by Lukas Zapletal 7 months ago

  • Related to Bug #25482: Excessive logging of OpenScap report via Rails added

Also available in: Atom PDF