Actions
Bug #21176
closedPlugin#parameter_filter doesn't work properly with block argument
Description
In plugin api for rex, we had
parameter_filter(Nic::Interface, :execution)
This didn't work, because the filter works only for non-nested params (which nic isn't).
Therefore, we needed to use block instead.
parameter_filter Nic::Interface do |ctx| ctx.permit :execution end
The problem is, we're using filter.pop
https://github.com/theforeman/foreman/blob/616669d83b0f568bbe0bf13013de042bbf4f3951/app/services/foreman/parameter_filter.rb#L19
which leads to the rules to loosing the saved block at the first call, and leads to the rules to not actually apply.
Updated by The Foreman Bot about 7 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/4886 added
Updated by Ivan Necas about 7 years ago
- Related to Bug #21178: unable to set non-primary remote execution interface added
Updated by Ivan Necas about 7 years ago
- Related to deleted (Bug #21178: unable to set non-primary remote execution interface)
Updated by Ivan Necas about 7 years ago
- Blocks Bug #21178: unable to set non-primary remote execution interface added
Updated by Ivan Necas about 7 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 44e3d9fe1999c363e6cb229afb4bcef5d38fd5a2.
Updated by Daniel Lobato Garcia about 7 years ago
- Translation missing: en.field_release set to 296
1.16 candidate?
Actions