Refactor #21205: Replace alias_method_chain with Module prepend - Foreman Remote Execution - Foreman

Actions

Refactor #21205

closed

Replace alias_method_chain with Module prepend

Added by Ivan Necas almost 7 years ago. Updated almost 7 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

-

Target version:

-

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman_remote_execution/pull/278

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

One of the reasons is to remove the rails 5 deprecation. The other is the tests
in against foreman on ruby 2.2.2 currently failing on

in HostTest.test_0100_#reload drops primary and provision interface cache
expected exactly once, invoked once: #<Host::Managed:0x1cf9a8a0>.drop_provision_interface_cache(any_parameters)
 (Minitest::Assertion)

The issues seems to be caused by super in https://github.com/theforeman/foreman/blob/715d097cbd058d171c8a2c65ad5d519d128d1123/app/models/host/base.rb#L290
calling the very same method once again, when called from `refresh_with_remote_execution`. Replacing alias_method_chain with
prepend seemed to help with the issue

Related issues 4 (0 open — 4 closed)

Actions

#1

Updated by The Foreman Bot almost 7 years ago

Status changed from Assigned to Ready For Testing
Pull request https://github.com/theforeman/foreman_remote_execution/pull/278 added

Actions

#2

Updated by Ivan Necas almost 7 years ago

Status changed from Ready For Testing to Closed
% Done changed from 0 to 100

Applied in changeset foreman_plugin|5d1530d6fba3b8e650b4323498501864df9ac55c.

Actions

#3

Updated by Ivan Necas almost 7 years ago

Related to Bug #21242: SystemStackError (stack level too deep) when calling smart proxy features refresh with Katello 3.4 added

Actions

#4

Updated by Ivan Necas almost 7 years ago

Related to Bug #21243: Rails 5 - Replace alias_method_chain with Module prepend added

Actions

#5

Updated by Ivan Necas almost 7 years ago

Related to Tracker #15715: Rails 5.0 upgrade tasks added

Actions

#6

Updated by Ivan Necas almost 7 years ago

Related to deleted (Tracker #15715: Rails 5.0 upgrade tasks)

Actions

#7

Updated by Ivan Necas almost 7 years ago

Related to Tracker #20948: Rails 5.1 upgrade tasks added

Actions

#8

Updated by Ivan Necas almost 7 years ago

Related to deleted (Tracker #20948: Rails 5.1 upgrade tasks)

Actions

#9

Updated by Ivan Necas almost 7 years ago

Blocks Tracker #20948: Rails 5.1 upgrade tasks added

Actions

#10

Updated by Lukas Zapletal almost 7 years ago

Related to Bug #14797: Medium validation wrong with Katello and foreman_bootdisk added

Actions

Also available in: Atom PDF