Project

General

Profile

Bug #2123

Package name mismatch: foreman-fog vs foreman-ec2

Added by Dominic Cleal over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

The Debian package for EC2 and Fog support is "foreman-fog", while the RPM package is "foreman-ec2". One of these should change for consistency in documentation etc. I'd suggest foreman-ec2 is correct, since it's self-explanatory as to what functionality it adds.

Associated revisions

Revision 3afbd145 (diff)
Added by Dominic Cleal about 6 years ago

fixes #2106, #2123, #2561 - sign RPMs, rename -ec2 to -compute, fix foreman.repo URLs

Revision 700122c4
Added by Sam Kottler about 6 years ago

Merge remote-tracking branch 'domcleal/rpms' into develop

  • domcleal/rpms:
    fixes #2555, #2560 - add foreman-release and MySQL gems to comps
    fixes #2106, #2123, #2561 - sign RPMs, rename -ec2 to -compute, fix foreman.repo URLs
    fixes #2573 - refresh Fedora 18 comps, don't force SCL

Revision c168e966 (diff)
Added by Dominic Cleal about 6 years ago

fixes #2106, #2123, #2561 - sign RPMs, rename -ec2 to -compute, fix foreman.repo URLs
(cherry picked from commit 3afbd14599a8f0cc2178df638f4570b68ad441ed)

Conflicts:
extras/packaging/rpm/sources/foreman.repo
foreman.spec

History

#1 Updated by Greg Sutcliffe over 6 years ago

I disagree. The fog packages are required for other compute resources (such as libvirt) and it then becomes non-intuitve as to why foreman-libvirt or foreman-vmware depends on foreman-ec2.

I have no issue with the supported technologies being listed in the description fields (which they are for debs), which is the correct place to list further information about what the package does.

#2 Updated by Greg Sutcliffe over 6 years ago

  • Status changed from New to Need more information

#3 Updated by Dominic Cleal over 6 years ago

That makes sense, so I think -fog would be better than -ec2. Is "foreman-compute" any clearer?

#4 Updated by Greg Sutcliffe over 6 years ago

The only thing it installs is "bundler.d/fog.rb" which only contains the fog gem. So I think it's ideally named as it is :)

#5 Updated by Sam Kottler over 6 years ago

I think both packages should be named foreman-compute, but at the very least they should be named the same thing. I think foreman-ec2 isn't a good name because then I'd expect a foreman-libvirt, foreman-ovirt, foreman-openstack, etc, but those don't exist. As a new user, I'd go for the foreman-compute package before foreman-fog. Just my $.02.

#6 Updated by Greg Sutcliffe over 6 years ago

Ok, i can run with that. I'll make the change in the next round of RC packages. Fortunately debs have an easy way to rename packages as part of an upgrade :)

#7 Updated by Greg Sutcliffe over 6 years ago

Fixed in the deb release. Sam, is your side done?

#8 Updated by Greg Sutcliffe about 6 years ago

  • Status changed from Need more information to Closed

Closing this, the compute rename was a while back.

#9 Updated by Greg Sutcliffe about 6 years ago

  • Status changed from Closed to Assigned
  • Assignee changed from Greg Sutcliffe to Sam Kottler
  • Target version set to 1.2

Re-opening, apparently the rpms haven't been renamed yet.

#10 Updated by Dominic Cleal about 6 years ago

  • Assignee changed from Sam Kottler to Dominic Cleal

#11 Updated by Sam Kottler about 6 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset commit:"700122c429c5d399f676b6ffdc3414ba694ea2e1".

Also available in: Atom PDF