Project

General

Profile

Bug #21243

Rails 5 - Replace alias_method_chain with Module prepend

Added by Ivan Necas almost 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

After we replaced alias_method_chain in remote execution, we're hitting
this when katello around. We're releasing 1.3.5 rex with reverting
the original patch (for 1.15/1.16) but in nightlies, the katello
should get rid or alias_mathod_chain as well, as those two don't work nicely
together

2017-10-09 07:12:07 8c03e5df [app] [I] Started PUT "/api/v2/smart_proxies/1/refresh" for 192.168.121.75 at 2017-10-09 07:12:07 +0000
2017-10-09 07:12:07 8c03e5df [app] [I] Processing by Api::V2::SmartProxiesController#refresh as JSON
2017-10-09 07:12:07 8c03e5df [app] [I]   Parameters: {"apiv"=>"v2", "id"=>"1", "smart_proxy"=>{}}
2017-10-09 07:12:07 8c03e5df [app] [I] Authorized user foreman_api_admin(API Admin)
2017-10-09 07:12:07 8c03e5df [app] [I] Current user: foreman_api_admin (administrator)
2017-10-09 07:12:07 8c03e5df [app] [I] Completed 500 Internal Server Error in 19ms (ActiveRecord: 1.8ms)
2017-10-09 07:12:08 8c03e5df [app] [F]
 | SystemStackError (stack level too deep):
 |   katello (3.4.5.6) app/models/katello/concerns/smart_proxy_extensions.rb:80:in `refresh_with_puppet_path'
 |   foreman_remote_execution (1.3.4) app/models/concerns/foreman_remote_execution/smart_proxy_extensions.rb:15:in `refresh'
 |   katello (3.4.5.6) app/models/katello/concerns/smart_proxy_extensions.rb:80:in `refresh_with_puppet_path'
 |   foreman_remote_execution (1.3.4) app/models/concerns/foreman_remote_execution/smart_proxy_extensions.rb:15:in `refresh'

Related issues

Related to Foreman Remote Execution - Bug #21242: SystemStackError (stack level too deep) when calling smart proxy features refresh with Katello 3.4Closed2017-10-09
Related to Foreman Remote Execution - Refactor #21205: Replace alias_method_chain with Module prepend Closed2017-10-05
Related to Boot disk - Bug #14797: Medium validation wrong with Katello and foreman_bootdiskClosed
Blocks Foreman - Tracker #20948: Rails 5.1 upgrade tasksClosed2017-09-16

Associated revisions

Revision a32a9be5 (diff)
Added by Justin Sherrill almost 2 years ago

Fixes #21243 - replace alias_method_chain

This replaces alias_method_chain instances
with use of prepend, and sets a convention
for overriding of foreman methods

History

#1 Updated by Ivan Necas almost 2 years ago

  • Related to Bug #21242: SystemStackError (stack level too deep) when calling smart proxy features refresh with Katello 3.4 added

#2 Updated by Ivan Necas almost 2 years ago

  • Related to Refactor #21205: Replace alias_method_chain with Module prepend added

#3 Updated by Ivan Necas almost 2 years ago

#4 Updated by Justin Sherrill almost 2 years ago

  • Legacy Backlogs Release (now unused) set to 284
  • Target version set to 225

#5 Updated by Brad Buckingham almost 2 years ago

  • Subject changed from Replace alias_method_chain with Module prepend to RAILS 5 - Replace alias_method_chain with Module prepend

#6 Updated by Brad Buckingham almost 2 years ago

  • Subject changed from RAILS 5 - Replace alias_method_chain with Module prepend to Rails 5 - Replace alias_method_chain with Module prepend

#7 Updated by Justin Sherrill almost 2 years ago

  • Status changed from New to Assigned

#8 Updated by Justin Sherrill almost 2 years ago

  • Assignee set to Justin Sherrill

#9 Updated by The Foreman Bot almost 2 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/7027 added

#10 Updated by Brad Buckingham almost 2 years ago

  • Target version changed from 225 to 232

#11 Updated by Justin Sherrill almost 2 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#12 Updated by Lukas Zapletal over 1 year ago

  • Related to Bug #14797: Medium validation wrong with Katello and foreman_bootdisk added

Also available in: Atom PDF