Project

General

Profile

Bug #21269

Template helper dns_lookup does not work with IP addresses

Added by Lukas Zapletal over 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Lukas Zapletal
Category:
Templates
Target version:
1.15.5
Difficulty:
Triaged:
Bugzilla link:
1364491
Pull request:
https://github.com/theforeman/foreman/pull/4905
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Although this was covered with tests, network things are stubbed for obvious reasons so we did not catch this. Method resolver.getname requires string and not IPAddress instance.

Associated revisions

Revision 90c7d2ba (diff)
Added by Lukas Zapletal over 5 years ago

Fixes #21269 - fixed dns_lookup with address resolution

Revision 0091e76b (diff)
Added by Lukas Zapletal over 5 years ago

Fixes #21269 - fixed dns_lookup with address resolution

Revision 5ee125db (diff)
Added by Lukas Zapletal over 5 years ago

Fixes #21269 - fixed dns_lookup with address resolution

History

#1 Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Lukas Zapletal
  • Pull request https://github.com/theforeman/foreman/pull/4905 added

#2 Updated by Lukas Zapletal over 5 years ago

  • Bugzilla link set to 1364491

I request 1.15.6, oneliner.

#3 Updated by Lukas Zapletal over 5 years ago

  • Legacy Backlogs Release (now unused) set to 311

#4 Updated by Lukas Zapletal over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF