Project

General

Profile

Actions

Refactor #21359

closed

Remove legacy code for Ruby < 2.0 from hammer-cli

Added by Tomáš Strachota over 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Hammer core
Target version:
-
Difficulty:
easy
Triaged:
No
Team Backlog:
Fixed in Releases:
Found in Releases:
In Kanboard:

Description

Hammer no longer supports ruby 2.0, there's no point of keeping the historical code.

From my search there's following places containing some compatibility code that should be removed:

./hammer/hammer-cli/lib/hammer_cli/utils.rb:
    2  class String
    3  
    4:   # string formatting for ruby 1.8
    5    def format(params)
    6      if params.is_a? Hash

./hammer/hammer-cli/lib/hammer_cli/output/adapter/csv.rb:
    1  require 'csv'
    2  if CSV.const_defined? :Reader
    3:   # Ruby 1.8 compatible
    4    require 'fastercsv'
    5    Object.send(:remove_const, :CSV)
    6    CSV = FasterCSV
    7  else
    8:   # CSV is now FasterCSV in ruby 1.9
    9  end
   10  

./hammer/hammer-cli/test/unit/history_test.rb:
    4  
    5    before :each do
    6:     # Readline::HISOTRY does not implement #clear in Ruby 1.8
    7      while not Readline::HISTORY.empty?
    8        Readline::HISTORY.pop

./hammer/hammer-cli/test/unit/i18n_test.rb:
   41    let(:unavailable_domain) { TestLocaleDomain.new('domain3', false) }
   42  
   43:   # skip the tests on older versions of fast_gettext (ruby 2.0)
   44    if FastGettext::VERSION >= '1.2.0'
   45      describe "with fast_gettext >= 1.2.0" do


Related issues 2 (0 open2 closed)

Related to Hammer CLI - Refactor #21360: Remove legacy code for Ruby <= 2.0 from hammer-cli-foremanClosedOleh FedorenkoActions
Related to Hammer CLI - Refactor #22549: Remove legacy Gemfile code for Ruby < 2.0Closed02/12/2018Actions
Actions #1

Updated by Tomáš Strachota over 6 years ago

  • Description updated (diff)
Actions #2

Updated by Tomáš Strachota over 6 years ago

  • Description updated (diff)
Actions #3

Updated by Tomáš Strachota over 6 years ago

  • Related to Refactor #21360: Remove legacy code for Ruby <= 2.0 from hammer-cli-foreman added
Actions #4

Updated by Tomáš Strachota about 6 years ago

  • Related to Refactor #22549: Remove legacy Gemfile code for Ruby < 2.0 added
Actions #5

Updated by Tomáš Strachota about 6 years ago

  • Description updated (diff)
Actions #6

Updated by The Foreman Bot about 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli/pull/269 added
Actions #7

Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/hammer-cli/pull/285 added
Actions #8

Updated by Oleh Fedorenko over 5 years ago

  • Assignee set to Oleh Fedorenko
Actions #9

Updated by Anonymous over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #10

Updated by Martin Bacovsky over 4 years ago

  • Fixed in Releases hammer-cli-0.15.0 added
Actions

Also available in: Atom PDF