Project

General

Profile

Bug #21381

Description of the bool option formatter shouldn't translate the values

Added by Tomáš Strachota over 1 year ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Oleh Fedorenko
Category:
Hammer core
Target version:
-
Difficulty:
trivial
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/hammer-cli/pull/279
Team Backlog:
Fixed in Releases:
hammer-cli 0.14.0
Found in Releases:

Description

Description of the bool option formatter now includes possible values in the translated string:

_("One of true/false, yes/no, 1/0.")

I've seen it translated into spanish. To prevent accidental translation to other languages, we should extract the values:

_("One of %s.") % ['true/false', 'yes/no', '1/0'].join(', ')

Associated revisions

Revision 0350ccbb (diff)
Added by Oleh Fedorenko 6 months ago

Fixes #21381 - Shouldn't translate the bool values in description

History

#1 Updated by Oleh Fedorenko 7 months ago

  • Triaged set to No
  • Assignee set to Oleh Fedorenko
  • Status changed from New to Assigned

#2 Updated by Oleh Fedorenko 6 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli/pull/279 added

#3 Updated by Oleh Fedorenko 6 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by The Foreman Bot 6 months ago

  • Pull request https://github.com/theforeman/hammer-cli/pull/280 added

#5 Updated by Martin Bacovsky 6 months ago

  • Pull request deleted (https://github.com/theforeman/hammer-cli/pull/280)

#6 Updated by Tomer Brisker 5 months ago

  • Fixed in Releases hammer-cli 0.14.0 added

Also available in: Atom PDF