Actions
Bug #21448
closednpm lint fails when plugin has additional dependencies
Description
The lint script in the foreman just includes files from plugins into a lint run executed from the context of the foreman. This causes troubles when a plugin adds some custom lint dependency (like eslint-plugin-jest from the example below).
[foreman|2.4.1|develop] npm run lint > TheForemanDevDeps@1.17.0 lint /home/vagrant/foreman/foreman > eslint -c .eslintrc webpack/ script/ $(./script/foreman_plugins_eslint.js) || exit 0 Oops! Something went wrong! :( ESLint couldn't find the plugin "eslint-plugin-jest". This can happen for a couple different reasons: 1. If ESLint is installed globally, then make sure eslint-plugin-jest is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin. 2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following: npm i eslint-plugin-jest@latest --save-dev If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.
Updated by The Foreman Bot over 7 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/4946 added
Updated by Walden Raines about 7 years ago
- Target version changed from 224 to 228
Updated by Daniel Lobato Garcia about 7 years ago
- Translation missing: en.field_release set to 296
Updated by Anonymous about 7 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 9d366d05693dfc1bee3e9a324bb05b80cfe892d8.
Actions