Project

General

Profile

Actions

Feature #21563

closed

Include babel-plugin-transform-class-properties so we can use static class variables

Added by Walden Raines over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

In order to do things like this:

class RedHatRepositoriesPage extends Component {
  static defaultProps = {
    redHatRepositoriesResponse: {},
    redHatRepositorySetsResponse: {}
  };

  static propTypes = {
    loadRedHatRepositories: PropTypes.func.isRequired,
    loadRedHatRepositorySets: PropTypes.func.isRequired,
    redHatRepositoriesResponse: PropTypes.object,
    redHatRepositorySetsResponse: PropTypes.object
  };

  ...

}

We need the babel plugin babel-plugin-transform-class-properties. To me, the above is clearer than:

class ChartBox extends React.Component {
  ...
}

ChartBox.PropTypes = {
  status: PropTypes.string.isRequired,
  config: PropTypes.object,
  modalConfig: PropTypes.object,
  id: PropTypes.string.isRequired,
  noDataMsg: PropTypes.string,
  errorText: PropTypes.string
};
Actions #1

Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4975 added
Actions #2

Updated by Walden Raines over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #3

Updated by Ohad Levy over 6 years ago

  • translation missing: en.field_release set to 296
Actions

Also available in: Atom PDF