Feature #215: Allow blank values for parameters - Foreman

Custom queries

3.11.5 release DONE
3.11.5 release TODO
3.12.2 release DONE
3.12.2 release TODO
3.13.0 release DONE
3.13.0 release TODO
All bugs by votes
All issues closed in the last 3 weeks
Easy and Trivial Issues
Easy Issues (only)
Foreman - new open issues in last 10 days
Good first issues - Foreman core
high prio open bugs
Host registration [open]
Mine
My issues closed in the last 3 weeks
old bugs
Open with target version set (aka blockers)
registration
taken-none
Team Atlas untriaged bugs
templates
Trivial Issues
Untriaged and opened in the past two weeks

Actions

Copy link

Feature #215

closed

Allow blank values for parameters

Added by Bash Shell over 14 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Ori Rabin

Category:

Host creation

Target version:

1.6.0

Difficulty:

Triaged:

Bugzilla link:

1120685

Pull request:

https://github.com/theforeman/foreman/pull/1610

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

If blank values for parameters are allowed, then one can do thing in templates like

<% !param_name.empty? -%>
<% do_some_thing -%>

This should be a pretty small change in parameter.rb .

Related issues 3 (0 open — 3 closed)

Is duplicate of Foreman - Bug #4319: Parameter with no value is not persisted in hostgroup	Duplicate		02/11/2014	Actions
Has duplicate Foreman - Bug #6697: UI doesn't raise any error when we add OS parameter without any value	Duplicate	Ori Rabin	07/21/2014	Actions
Has duplicate Foreman - Bug #1512: Cannot give parameter empty value	Duplicate		02/28/2012	Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Ohad Levy over 14 years ago

Status changed from New to Feedback
Assignee set to Bash Shell

Bash Shell wrote:

If blank values for parameters are allowed, then one can do thing in templates like

[...]

This should be a pretty small change in parameter.rb .

that's actually not true, as when saving the host model with the parameters (which is another model), the way to detect if there are new parameters is based on if the value is empty or not.

I'm not sure if that's such a useful feature, as you can also use:

<% if has_variable?("myvar") then %>

Actions

Copy link

Updated by Bash Shell over 14 years ago

Like we discussed on IRC, it would be great if users have the option of having blank values.

We use it in a couple of ways in our templates. (hard to describe, I know)

This is also valid YAML, so it would be great to have that option.

Actions

Copy link

Updated by Ohad Levy about 14 years ago

the problem is that the current implementation detect the presence of parameters based on the parameter value... (e.g. it gets deleted if the value is blank).
Patches are welcomed :)

Actions

Copy link