Project

General

Profile

Bug #21600

Panel component should be based on react-bootstrap

Added by Avi Sharvit about 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Avi Sharvit
Category:
Web Interface
Target version:
1.17.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4990
Fixed in Releases:
Found in Releases:

Description

We can remove all these files:
https://github.com/theforeman/foreman/tree/develop/webpack/assets/javascripts/react_app/components/common/Panel

And switch to use the react-bootstrap implementation:
https://react-bootstrap.github.io/components.html#panels

The only component who use this Panel is the ChartBox:
https://github.com/theforeman/foreman/blob/develop/webpack/assets/javascripts/react_app/components/statistics/ChartBox.js

Associated revisions

Revision 1c644904 (diff)
Added by Avi Sharvit about 3 years ago

Fixes #21600 - react-bootstrap Panel

Remove the Panel implementation and switch to use react-bootstrap
implementaion for panels.

http://projects.theforeman.org/issues/21600

History

#1 Updated by The Foreman Bot about 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4990 added

#2 Updated by Tomer Brisker about 3 years ago

  • Legacy Backlogs Release (now unused) set to 296

#3 Updated by Anonymous about 3 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF