Project

General

Profile

Actions

Feature #21624

closed

Remove custom eslint rules in favor of airbnb-base config

Added by Dan Seethaler over 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Fixed in Releases:
Found in Releases:

Description

This is to remove all the custom rules we currently have in the .eslintrc in favor of a simpler extension of the airbnb config.

Actions #1

Updated by Dan Seethaler over 6 years ago

  • Subject changed from Remove custom eslint rules in favor of airbnb config to Remove custom eslint rules in favor of airbnb-base config

Eventually we'll want to to move to the full airbnb config with react and a11y. The reason to not go there immediately is because many of the react rules are not followed in our code base and refactoring would take a lot of time and research to understand each component. This approach allows us to make the move to the base config and fix all the linting errors in the code base. Then make a second pass and update to the full airbnb config without actually updating all the components.

Actions #2

Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4997 added
Actions #3

Updated by Walden Raines over 6 years ago

  • Target version set to 228
Actions #4

Updated by Marek Hulán over 6 years ago

  • translation missing: en.field_release set to 296
Actions #5

Updated by Anonymous over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #6

Updated by The Foreman Bot over 6 years ago

  • Pull request https://github.com/theforeman/foreman/pull/5074 added
Actions

Also available in: Atom PDF