Feature #21624: Remove custom eslint rules in favor of airbnb-base config - Foreman

Feature #21624

Remove custom eslint rules in favor of airbnb-base config

Added by Dan Seethaler almost 3 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Dan Seethaler

Category:

Target version:

1.17.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/4997, https://github.com/theforeman/foreman/pull/5074

Fixed in Releases:

Found in Releases:

Description

This is to remove all the custom rules we currently have in the .eslintrc in favor of a simpler extension of the airbnb config.

Associated revisions

Revision a5a6b5df (diff)
Added by Dan Seethaler almost 3 years ago

Fixes #21624 - eslint update to airbnb-base

Replace existing custom rules with airbnb-base config.
Eventually we'll want to to move to the full airbnb config
with react and a11y.

http://projects.theforeman.org/issues/21624

Revision f6a8dce1 (diff)
Added by Tomer Brisker almost 3 years ago

Refs #21624 - Correctly load CR tables

Arrow functions don't change `this` context, we need the elements.

History

#1 Updated by Dan Seethaler almost 3 years ago

Subject changed from Remove custom eslint rules in favor of airbnb config to Remove custom eslint rules in favor of airbnb-base config

Eventually we'll want to to move to the full airbnb config with react and a11y. The reason to not go there immediately is because many of the react rules are not followed in our code base and refactoring would take a lot of time and research to understand each component. This approach allows us to make the move to the base config and fix all the linting errors in the code base. Then make a second pass and update to the full airbnb config without actually updating all the components.