Project

General

Profile

Bug #21718

Clicking "Load DataCenters" with no url on a new compute resource causes an error instead of validation message

Added by Adam Ruzicka almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Compute resources - oVirt
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1481991

Description of problem: Creating a new RHEV compute resource with no url presents an error message "undefined method `+' for nil:NilClass" instead of showing a validation error about the empty url.

Version-Release number of selected component (if applicable): 6.3 Snap 11

Steps to Reproduce:
1. Go to "Infrastructure" -> "Compute resources"
2. Click "Create compute resource"
3. Choose "Provider" RHEV
4. Click "Load Datacenters"

Actual results: undefined method `+' for nil:NilClass

Expected results: validation message: url can't be blank

Additional info: When clicking submit instead of "Load Datacenters" the same message appears with "Oops, we're sorry but something went wrong undefined method `+' for nil:NilClass" (screenshot attached)

Screenshot_20171121_122143.png View Screenshot_20171121_122143.png 47.2 KB Adam Ruzicka, 11/21/2017 11:22 AM
Screenshot 20171121 122143

Associated revisions

Revision 9a8b3b8f (diff)
Added by Adam Ruzicka almost 3 years ago

Fixes #21718 - Show errors properly when creating new oVirt CR

We try to retrieve available operating systems in an after_validation
hook. Trying to retrieve them makes no sense if the URL isn't
considered valid by us.

History

#1 Updated by Adam Ruzicka almost 3 years ago

The following block shouldn't be displayed in this case, validations next to the URL field are enough.

Unable to save
bad URI(no host provided): http:///datacenters?search=

#2 Updated by The Foreman Bot almost 3 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5015 added

#3 Updated by Ivan Necas almost 3 years ago

  • Legacy Backlogs Release (now unused) set to 296
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF