Bug #21718
Clicking "Load DataCenters" with no url on a new compute resource causes an error instead of validation message
Description
Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1481991
Description of problem: Creating a new RHEV compute resource with no url presents an error message "undefined method `+' for nil:NilClass" instead of showing a validation error about the empty url.
Version-Release number of selected component (if applicable): 6.3 Snap 11
Steps to Reproduce:
1. Go to "Infrastructure" -> "Compute resources"
2. Click "Create compute resource"
3. Choose "Provider" RHEV
4. Click "Load Datacenters"
Actual results: undefined method `+' for nil:NilClass
Expected results: validation message: url can't be blank
Additional info: When clicking submit instead of "Load Datacenters" the same message appears with "Oops, we're sorry but something went wrong undefined method `+' for nil:NilClass" (screenshot attached)
History
#1
Updated by Adam Ruzicka about 3 years ago
Updated by - Target version set to 233
- Assignee set to Adam Ruzicka
- Status changed from New to Assigned
- File Screenshot_20171121_122143.png Screenshot_20171121_122143.png added
The following block shouldn't be displayed in this case, validations next to the URL field are enough.
Unable to save
bad URI(no host provided): http:///datacenters?search=
#2
Updated by The Foreman Bot about 3 years ago
Updated by - Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/5015 added
#3
Updated by Ivan Necas about 3 years ago
Updated by 
- Legacy Backlogs Release (now unused) set to 296
- Status changed from Ready For Testing to Closed
Fixes #21718 - Show errors properly when creating new oVirt CR
We try to retrieve available operating systems in an after_validation
hook. Trying to retrieve them makes no sense if the URL isn't
considered valid by us.