Project

General

Profile

Bug #21721

foreman-maintain lower cases the uppercase characters while saving hammer credentials

Added by Anurag Patel over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
High
Assignee:
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

From the Bugzilla
~~~~~~~~~~~~~~~
Description of problem:
foreman-maintain lower cases the uppercase characters while saving hammer credentials

Version-Release number of selected component (if applicable):
rubygem-foreman_maintain-0.0.11-1.el7sat.noarch

How reproducible:
Always

Steps to Reproduce:
1. Say Satellite hammer password is CHANGEME!@#$%
2. Install rubygem-foreman_maintain
3. Run any foreman-maintain command: Example:
  1. foreman-maintain upgrade check --target-version 6.3.z

Running preparation steps required to run the next scenarios ================================================================================
Setup hammer:
Hammer username [admin]:
Hammer password:
Invalid credentials

Actual results:
The foreman-maintain fails with invalid credentials even though you enter the right password

/etc/foreman-maintain/foreman-maintain-hammer.yml saves the password as `changeme!@#$%`

All the upper case characters are lowercased. As far as I checked, the special characters look fine.

Expected results:
credentials should be saved properly

Additional info:
Changing the credentials in /etc/foreman-maintain/foreman-maintain-hammer.yml works fine.


Related issues

Has duplicate Foreman Maintain - Bug #21793: foreman-maintain does not accept passwords in Capital lettersDuplicate2017-11-28

Associated revisions

Revision 52dc72e1 (diff)
Added by Anurag Patel over 1 year ago

Fixes #21721 - Don't downcase stdin if its hammer credentials

Removed .downcase call from ask() method. downcase of answer is only
performed in filter_decision method now.

History

#1 Updated by Anurag Patel over 1 year ago

  • Project changed from Foreman to Foreman Maintain

#2 Updated by The Foreman Bot over 1 year ago

  • Pull request https://github.com/theforeman/foreman_maintain/pull/126 added

#3 Updated by Kavita Gaikwad over 1 year ago

  • Has duplicate Bug #21793: foreman-maintain does not accept passwords in Capital letters added

#4 Updated by Anonymous over 1 year ago

  • % Done changed from 0 to 100
  • Status changed from Assigned to Closed

Also available in: Atom PDF