Project

General

Profile

Actions

Refactor #21735

closed

Use prepend instead of include for overrides from foreman-tasks

Added by Ondřej Pražák over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Branch:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Some of the modules from foreman-tasks override the parent method. Since we removed alias_method_chain, we need to use prepend instead of include.

Actions #1

Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/7083 added
Actions #2

Updated by Justin Sherrill over 6 years ago

  • translation missing: en.field_release set to 284
Actions #3

Updated by The Foreman Bot over 6 years ago

  • Pull request https://github.com/Katello/katello/pull/7126 added
Actions #4

Updated by Ondřej Pražák over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Andrew Kofink about 6 years ago

  • translation missing: en.field_release changed from 284 to 329

Including in Katello 3.5.1, which uses foreman-tasks 0.11.0.

Actions #6

Updated by The Foreman Bot about 6 years ago

  • Pull request https://github.com/Katello/katello/pull/7173 added
Actions #7

Updated by Andrew Kofink about 6 years ago

  • translation missing: en.field_release changed from 329 to 284

Pinned Katello 3.5.1 to foreman-tasks < 0.11

Actions #8

Updated by Andrew Kofink about 6 years ago

  • Pull request deleted (https://github.com/Katello/katello/pull/7173)
Actions

Also available in: Atom PDF