Project

General

Profile

Actions
Copy link

Refactor #21735

closed

Use prepend instead of include for overrides from foreman-tasks

Added by Ondřej Pražák almost 7 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Pražák
Category:
-
Target version:
Katello 3.6.0
Branch:
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/Katello/katello/pull/7083, https://github.com/Katello/katello/pull/7126
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Some of the modules from foreman-tasks override the parent method. Since we removed alias_method_chain, we need to use prepend instead of include.

Actions
Copy link
 #1

Updated by The Foreman Bot almost 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/7083 added
Actions
Copy link
 #2

Updated by Justin Sherrill almost 7 years ago

  • Translation missing: en.field_release set to 284
Actions
Copy link
 #3

Updated by The Foreman Bot almost 7 years ago

  • Pull request https://github.com/Katello/katello/pull/7126 added
Actions
Copy link
 #4

Updated by Ondřej Pražák almost 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Andrew Kofink over 6 years ago

  • Translation missing: en.field_release changed from 284 to 329

Including in Katello 3.5.1, which uses foreman-tasks 0.11.0.

Actions
Copy link
 #6

Updated by The Foreman Bot over 6 years ago

  • Pull request https://github.com/Katello/katello/pull/7173 added
Actions
Copy link
 #7

Updated by Andrew Kofink over 6 years ago

  • Translation missing: en.field_release changed from 329 to 284

Pinned Katello 3.5.1 to foreman-tasks < 0.11

Actions
Copy link
 #8

Updated by Andrew Kofink over 6 years ago

  • Pull request deleted (https://github.com/Katello/katello/pull/7173)
Actions
Copy link

Also available in: Atom PDF