Bug #21772: api does not allow to reject an already accepted key - Salt - Foreman

Actions

Copy link

Bug #21772

closed

api does not allow to reject an already accepted key

Added by Dominic Schlegel over 6 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman_salt/pull/75

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

as per the current code in [1] it is not possible to reject an already accepted salt key. is there any reason behind it? i can't think of a use case that would justify this. i have the situation where i would like to explicitly reject an accepted key for a certain time before i am going to finally delete it.

[1] https://github.com/theforeman/foreman_salt/blob/master/app/services/foreman_salt/smart_proxies/salt_keys.rb#L40

may the original author of these lines @Stephen Benjamin can comment on this.

Actions

Copy link

Updated by Dominic Schlegel over 6 years ago

looks like the underlying foreman salt proxy module is not using the right commands. currently the cli does not select rejected keys so the key are never found. by using the --include-accepted the glob is able to match. same is possible for accepting a rejected key. we can use the cli option --include-rejected there.

i have created the following pull request that handles the smart proxy part: https://github.com/theforeman/smart_proxy_salt/pull/29

Actions

Copy link