Bug #21809

Visiting /smart_proxies/:id with Bastion fails 'undefined method include_plugin_styles'

Added by Daniel Lobato Garcia 8 months ago. Updated 8 days ago.

Status:Closed
Priority:Normal
Assignee:Tomáš Strachota
Category:-
Target version:Katello 3.5.0
Difficulty: Team Backlog:
Triaged:Yes Fixed in Releases:
Bugzilla link: Found in Releases:
Pull request:https://github.com/Katello/katello/pull/7105, https://github.com/Katello/katello/pull/7104

Description

When going to the smart proxies list and clicking on a random proxy, the following error shows up, and the page renders a 500:

| NoMethodError - undefined method `include_plugin_styles' for #<#&lt;Class:0x007f955d95ff98&gt;:0x000000030b21f8>:
|   /home/vagrant/bastion/app/views/bastion/layouts/assets.html.erb:8:in `block (2 levels) in _8111bf94c2ef01dda727efb8ee6f12cf'
|   /home/vagrant/bastion/app/views/bastion/layouts/assets.html.erb:7:in `each'
|   /home/vagrant/bastion/app/views/bastion/layouts/assets.html.erb:7:in `block in _8111bf94c2ef01dda727efb8ee6f12cf'
|   /home/vagrant/bastion/app/views/bastion/layouts/assets.html.erb:5:in `_8111bf94c2ef01dda727efb8ee6f12cf'
|   /home/vagrant/katello/app/views/katello/layouts/foreman_with_bastion.html.erb:5:in `_df8737a93e1e9b8cea1e1189f89a2014'
|   /home/vagrant/katello/app/controllers/katello/concerns/smart_proxies_controller_extensions.rb:9:in `show'
|   app/controllers/concerns/application_shared.rb:15:in `set_timezone'
|   app/models/concerns/foreman/thread_session.rb:32:in `clear_thread'
|   app/controllers/concerns/foreman/controller/topbar_sweeper.rb:12:in `set_topbar_sweeper_controller'
|   lib/middleware/catch_json_parse_errors.rb:8:in `call'
|   lib/middleware/session_safe_logging.rb:17:in `call'
|   lib/middleware/tagged_logging.rb:18:in `call'
|   /home/vagrant/katello/lib/katello/prevent_json_parsing.rb:12:in `call'

Related issues

Duplicated by Katello - Bug #21891: Clicking on smart proxy server stopped working after 3.5r... Duplicate 12/06/2017

Associated revisions

Revision 652ba187
Added by Tomáš Strachota 7 months ago

Fixes #21809 - include bastion helpers for the proxy detail page

History

#1 Updated by Andrew Kofink 8 months ago

Seeing this bug in Katello 3.5.0/Bastion 6.1.5.

2017-12-05 20:51:05 9655ead1 [app] [I] Started GET "/smart_proxies/1-pipeline-katello-3-5-centos7-akofink-desktop-example-com/ping" for 192.168.121.1 at 2017-12-05 20:51:05 +0000
2017-12-05 20:51:05 9655ead1 [app] [I] Processing by SmartProxiesController#ping as */*
2017-12-05 20:51:05 9655ead1 [app] [I]   Parameters: {"id"=>"1-pipeline-katello-3-5-centos7-akofink-desktop-example-com"}
2017-12-05 20:51:05 9655ead1 [app] [I] Current user: admin (administrator)
2017-12-05 20:51:05 9655ead1 [app] [I] Completed 200 OK in 234ms (Views: 0.7ms | ActiveRecord: 11.3ms)
2017-12-05 20:51:08 ff8b9860 [app] [I] Started GET "/smart_proxies/1-pipeline-katello-3-5-centos7-akofink-desktop-example-com" for 192.168.121.1 at 2017-12-05 20:51:08 +0000
2017-12-05 20:51:08 ff8b9860 [app] [I] Processing by SmartProxiesController#show as HTML
2017-12-05 20:51:08 ff8b9860 [app] [I]   Parameters: {"id"=>"1-pipeline-katello-3-5-centos7-akofink-desktop-example-com"}
2017-12-05 20:51:08 ff8b9860 [app] [I] Current user: admin (administrator)
2017-12-05 20:51:08 ff8b9860 [app] [I]   Rendered /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.5.0/app/views/smart_proxies/show/_storage.html.erb (1.9ms)
2017-12-05 20:51:08 ff8b9860 [app] [I]   Rendered smart_proxies/plugins/_plugin_version.html.erb (0.6ms)
2017-12-05 20:51:08 ff8b9860 [app] [I]   Rendered /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.5.0/app/views/smart_proxies/plugins/_pulp.html.erb (3.0ms)
2017-12-05 20:51:08 ff8b9860 [app] [I]   Rendered smart_proxies/plugins/_plugin_version.html.erb (0.3ms)
2017-12-05 20:51:08 ff8b9860 [app] [I]   Rendered smart_proxies/plugins/_tftp.html.erb (1.2ms)
2017-12-05 20:51:08 ff8b9860 [app] [I]   Rendered smart_proxies/plugins/_plugin_version.html.erb (0.3ms)
2017-12-05 20:51:08 ff8b9860 [app] [I]   Rendered smart_proxies/plugins/_no_template.html.erb (1.0ms)
2017-12-05 20:51:08 ff8b9860 [app] [I]   Rendered smart_proxies/plugins/_logs.html.erb (0.6ms)
2017-12-05 20:51:08 ff8b9860 [app] [I]   Rendered smart_proxies/plugins/_plugin_version.html.erb (0.2ms)
2017-12-05 20:51:08 ff8b9860 [app] [I]   Rendered smart_proxies/plugins/_puppet.html.erb (5.4ms)
2017-12-05 20:51:08 ff8b9860 [app] [I]   Rendered smart_proxies/plugins/_plugin_version.html.erb (0.4ms)
2017-12-05 20:51:08 ff8b9860 [app] [I]   Rendered smart_proxies/plugins/_puppet_ca.html.erb (7.3ms)
2017-12-05 20:51:08 ff8b9860 [app] [I]   Rendered smart_proxies/show.html.erb (77.3ms)
2017-12-05 20:51:08 ff8b9860 [app] [I]   Rendered /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.5.0/app/views/foreman/smart_proxies/show.html.erb within katello/layouts/foreman_with_bastion (80.2ms)
2017-12-05 20:51:08 ff8b9860 [app] [I]   Rendered layouts/_application_content.html.erb (0.7ms)
2017-12-05 20:51:09 ff8b9860 [app] [I]   Rendered /opt/theforeman/tfm/root/usr/share/gems/gems/bastion-6.1.5/app/views/bastion/layouts/assets.html.erb (287.0ms)
2017-12-05 20:51:09 ff8b9860 [app] [W] Action failed
| NoMethodError: undefined method `include_plugin_styles' for #<#<Class:0x007f0b08e3a070>:0x007f0b10053210>
| /opt/theforeman/tfm/root/usr/share/gems/gems/bastion-6.1.5/app/views/bastion/layouts/assets.html.erb:8:in `block (2 levels) in _37cee4c3de5e887347e841ddc8d27523'
| /opt/theforeman/tfm/root/usr/share/gems/gems/bastion-6.1.5/app/views/bastion/layouts/assets.html.erb:7:in `each'
| /opt/theforeman/tfm/root/usr/share/gems/gems/bastion-6.1.5/app/views/bastion/layouts/assets.html.erb:7:in `block in _37cee4c3de5e887347e841ddc8d27523'
| /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2.5.1/lib/action_view/helpers/capture_helper.rb:38:in `block in capture'
| /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2.5.1/lib/action_view/helpers/capture_helper.rb:202:in `with_output_buffer'
| /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2.5.1/lib/action_view/helpers/capture_helper.rb:38:in `capture'
| /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2.5.1/lib/action_view/helpers/capture_helper.rb:152:in `content_for'
| /opt/theforeman/tfm/root/usr/share/gems/gems/bastion-6.1.5/app/views/bastion/layouts/assets.html.erb:5:in `_37cee4c3de5e887347e841ddc8d27523'
| /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2.5.1/lib/action_view/template.rb:145:in `block in render'
| /opt/rh/sclo-ror42/root/usr/share/gems/gems/activesupport-4.2.5.1/lib/active_support/notifications.rb:166:in `instrument'
| /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2.5.1/lib/action_view/template.rb:333:in `instrument'

#2 Updated by Walden Raines 8 months ago

  • Target version set to 234
  • Assignee set to Tomáš Strachota

#3 Updated by Walden Raines 8 months ago

Tomas, do you mind having a look at this please?

#4 Updated by Tomáš Strachota 7 months ago

  • Status changed from New to Assigned

#5 Updated by Tomáš Strachota 7 months ago

  • Project changed from Bastion to Katello

#6 Updated by The Foreman Bot 7 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/7104 added

#7 Updated by Andrew Kofink 7 months ago

  • Legacy Backlogs Release (now unused) set to 250

#8 Updated by The Foreman Bot 7 months ago

  • Pull request https://github.com/Katello/katello/pull/7105 added

#9 Updated by Andrew Kofink 7 months ago

  • Pull request deleted (https://github.com/Katello/katello/pull/7105)

#10 Updated by Tomáš Strachota 7 months ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#11 Updated by The Foreman Bot 7 months ago

  • Pull request https://github.com/Katello/katello/pull/7105 added

#12 Updated by Justin Sherrill 7 months ago

  • Duplicated by Bug #21891: Clicking on smart proxy server stopped working after 3.5rc upgrade added

Also available in: Atom PDF