Project

General

Profile

Bug #21846

Notification drawer close on click outside is not working well

Added by Avi Sharvit over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Avi Sharvit
Category:
Web Interface
Target version:
1.17.0
Difficulty:
Triaged:
Bugzilla link:
1527896
Pull request:
https://github.com/theforeman/foreman/pull/5083
Fixed in Releases:
Found in Releases:

Description

Notification drawer can get closed when clicking inside the drawer

Related issues

Has duplicate Katello - Bug #21480: Disable turbolinks reloading on back button navigationDuplicate2017-10-26

Associated revisions

Revision 1fe258bb (diff)
Added by Avi Sharvit over 2 years ago

Fixes #21846 - React turbolinks fix

In order to support turbolinks with react, need to
unmount all root components before turbolinks do the unload

It fix the issue with the notification drawer and the on-click-outside
http://projects.theforeman.org/issues/21846

History

#1 Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5047 added

#2 Updated by The Foreman Bot over 2 years ago

  • Pull request https://github.com/theforeman/foreman/pull/5083 added

#3 Updated by Anonymous over 2 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#4 Updated by Ohad Levy over 2 years ago

  • Legacy Backlogs Release (now unused) set to 296
  • Pull request deleted (https://github.com/theforeman/foreman/pull/5047)

#5 Updated by Walden Raines over 2 years ago

  • Has duplicate Bug #21480: Disable turbolinks reloading on back button navigation added

#6 Updated by Tomer Brisker over 2 years ago

  • Bugzilla link set to 1527896

Also available in: Atom PDF