Project

General

Profile

Actions

Bug #22037

open

Compute attributes create and update API miss validations

Added by Tomáš Strachota over 6 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
API
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Compute attributes crate and update API actions don't validate the attributes. It blindly accepts and saves any hash. That can easily lead to storing wrong values without any feedback for users. Such compute attribute can later break UI forms and cause undefined behavior in the provisioning process.

The same validations should be performed on host create API: http://projects.theforeman.org/issues/3649

Expected behavior:
The API actions must check keys and values of compute attributes and return meaningful error messages.

Currently the keys and values differ quite a lot across the providers. http://projects.theforeman.org/issues/21580/ normalizes them for the read actions. Validations should accept the same keys and values and be consistent with the normalized output.


Related issues 4 (2 open2 closed)

Related to Foreman - Bug #21580: Compute attributes returned from api need to be normalizedClosedTomáš Strachota11/05/2017Actions
Related to Foreman - Bug #3649: Hosts need validations of compute attributesNewActions
Related to Hammer CLI - Feature #20538: Commands for creating, updating and deleting compute profiles and attributesResolvedShira MaximovActions
Related to Foreman - Bug #23466: Unable to provision host with hammer after upgrade to 1.16.1NewActions
Actions #1

Updated by Tomáš Strachota over 6 years ago

  • Related to Bug #21580: Compute attributes returned from api need to be normalized added
Actions #2

Updated by Tomáš Strachota over 6 years ago

  • Related to Bug #3649: Hosts need validations of compute attributes added
Actions #3

Updated by Tomáš Strachota over 6 years ago

  • Related to Feature #20538: Commands for creating, updating and deleting compute profiles and attributes added
Actions #4

Updated by Tomáš Strachota over 5 years ago

  • Related to Bug #23466: Unable to provision host with hammer after upgrade to 1.16.1 added
Actions

Also available in: Atom PDF