Project

General

Profile

Refactor #22045

make Rails 5.1 compatible

Added by Michael Moll over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Plugin (foreman_docker)
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Related issues

Related to Foreman - Tracker #20948: Rails 5.1 upgrade tasksClosed2017-09-16

Associated revisions

Revision fb471374 (diff)
Added by Michael Moll over 1 year ago

Update to Rails 5.1

  • Fixes #21814 - Add Rails 5 migrations
  • Refs #22045 - update TargetRailsVersion for rubocop
  • Refs #22045 - use ApplicationRecord
  • Refs #22045 - stop using HttpPositionalArguments
  • Fixes #22046 - use rubocop 0.52

Revision fb471374 (diff)
Added by Michael Moll over 1 year ago

Update to Rails 5.1

  • Fixes #21814 - Add Rails 5 migrations
  • Refs #22045 - update TargetRailsVersion for rubocop
  • Refs #22045 - use ApplicationRecord
  • Refs #22045 - stop using HttpPositionalArguments
  • Fixes #22046 - use rubocop 0.52

Revision 00bd7de4 (diff)
Added by Michael Moll over 1 year ago

More Rails 5.1 changes

  • Refs #22045 - Remove condition to destroy_all
  • Refs #22045 - Replace 'xhr' in tests with keyword argument
  • Refs #22045 - Replace deprecated AM::Errors usage
  • Refs #22045 - replace deprecated ActiveRecord_Relation access

Revision 00bd7de4 (diff)
Added by Michael Moll over 1 year ago

More Rails 5.1 changes

  • Refs #22045 - Remove condition to destroy_all
  • Refs #22045 - Replace 'xhr' in tests with keyword argument
  • Refs #22045 - Replace deprecated AM::Errors usage
  • Refs #22045 - replace deprecated ActiveRecord_Relation access

History

#1 Updated by Michael Moll over 1 year ago

#2 Updated by The Foreman Bot over 1 year ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-docker/pull/207 added

#3 Updated by Michael Moll over 1 year ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF