Project

General

Profile

Refactor #22089

scope "without" on TaxableTaxonomy blows up with Rails 5.2

Added by Anonymous over 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Rails
Target version:
1.17.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/5129
Fixed in Releases:
Found in Releases:
Nightly

Description

app/models/taxable_taxonomy.rb defines a scope named "without". Since Rails 5.0 (https://github.com/rails/rails/commit/c7a37c10ade8372c712be01a7e4ddbe8785c5139) there's a "without" in ActiveSupport and Rails 5.2 does check this now and fails:

You tried to define a scope named "without" on the model "TaxableTaxonomy", but ActiveRecord::Relation already defined an instance method with the same name."

Related issues

Blocks Foreman - Tracker #21834: Rails 5.2 upgrade tasksClosed

Associated revisions

Revision 85ecc9b8 (diff)
Added by Michael Moll over 3 years ago

Fixes #22089 - remove unused scope

History

#1 Updated by Anonymous over 3 years ago

#2 Updated by The Foreman Bot over 3 years ago

  • Assignee set to Anonymous
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5129 added

#3 Updated by Tomer Brisker over 3 years ago

  • Legacy Backlogs Release (now unused) set to 296

#4 Updated by Anonymous over 3 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF