Project

General

Profile

Refactor #22110

Update minitest to > 5.10

Added by Anonymous about 4 years ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Evgeni Golov
Category:
Tests
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/5138, https://github.com/theforeman/foreman/pull/8969
Fixed in Releases:
3.2.0
Found in Releases:

Description

ArgumentError: let 'klass' cannot override a method in Minitest::Spec. Please use another name.
/home/travis/.rvm/gems/ruby-2.5.0/gems/minitest-5.11.0/lib/minitest/spec.rb:242:in `let'
/home/travis/build/mmoll/foreman/test/unit/parameter_filter_test.rb:4:in `<class:ParameterFilterTest>'
/home/travis/build/mmoll/foreman/test/unit/parameter_filter_test.rb:3:in `<top (required)>'

Related issues

Blocked by Foreman - Refactor #22601: Update Rails to 5.1.6Closed2018-02-15
Blocked by Foreman - Refactor #26968: Update minitest plugin for junit-XML generationClosed

Associated revisions

Revision 406b3fb3 (diff)
Added by Michael Moll about 4 years ago

Refs #22110 - pin minitest gem

Revision 1f8c9411 (diff)
Added by Evgeni Golov about 2 months ago

Fixes #22110 - allow minitest 5.11 and newer

History

#1 Updated by Anonymous about 4 years ago

  • Legacy Backlogs Release (now unused) set to 332

#2 Updated by The Foreman Bot about 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/5138 added

#3 Updated by The Foreman Bot about 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/5139 added

#4 Updated by The Foreman Bot about 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/5144 added

#5 Updated by Anonymous about 4 years ago

  • Legacy Backlogs Release (now unused) deleted (332)

unstetting release as workaround is in place and https://github.com/seattlerb/minitest/issues/729 needs to get resolved first

#6 Updated by Anonymous over 3 years ago

#7 Updated by Anonymous over 2 years ago

  • Status changed from Ready For Testing to New
  • Pull request deleted (https://github.com/theforeman/foreman/pull/5139, https://github.com/theforeman/foreman/pull/5144)

#8 Updated by Anonymous over 2 years ago

  • Blocked by Refactor #26968: Update minitest plugin for junit-XML generation added

#9 Updated by Anonymous over 2 years ago

  • Assignee deleted (Anonymous)
  • Subject changed from tests fail with minitest 5.11 to Update minitest to > 5.10
  • Tracker changed from Bug to Refactor

#10 Updated by The Foreman Bot about 2 months ago

  • Assignee set to Evgeni Golov
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8969 added

#11 Updated by The Foreman Bot about 2 months ago

  • Fixed in Releases 3.2.0 added

#12 Updated by Evgeni Golov about 2 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF