Project

General

Profile

Refactor #22152

upgrade record_tag_helper

Added by Anonymous over 4 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
High
Assignee:
Tomer Brisker
Category:
Rails
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman-packaging/pull/4484
Fixed in Releases:
Found in Releases:

Description

record_tag_helper contains stuff that was extracted from Rails 4 and removed from Rails 5. We should stop using the provided methods and remove this gem.

Related issues

Related to Foreman - Tracker #15715: Rails 5.0 upgrade tasksResolved2016-07-18

Related to Foreman - Tracker #20948: Rails 5.1 upgrade tasksClosed2017-09-16

Related to Foreman - Tracker #21834: Rails 5.2 upgrade tasksClosed

Related to Foreman - Refactor #28571: Remove usage of content_tag_for & div_for helpers so we can drop record_tag_helperClosed
Blocks Foreman - Tracker #24837: Rails 6.0 TrackerClosed

History

#1 Updated by Anonymous over 4 years ago

#2 Updated by Anonymous over 4 years ago

#3 Updated by Anonymous over 4 years ago

#4 Updated by Anonymous almost 4 years ago

#5 Updated by Tomer Brisker over 2 years ago

  • Priority changed from Low to High
  • Subject changed from move away from record_tag_helper to upgrade record_tag_helper

record_tag_helper is now compatible with rails 6, only need to upgrade to 1.0.1 version.

#6 Updated by Tomer Brisker over 2 years ago

  • Assignee set to Tomer Brisker
  • Status changed from New to Assigned
  • Pull request https://github.com/theforeman/foreman-packaging/pull/4484 added

core already permits 1.0.1, just need to bump the packaged rpm version

#7 Updated by Tomer Brisker over 2 years ago

  • Status changed from Assigned to Resolved

#8 Updated by Anonymous over 2 years ago

  • Related to Refactor #28571: Remove usage of content_tag_for & div_for helpers so we can drop record_tag_helper added

Also available in: Atom PDF