Project

General

Profile

Bug #2217

Successfull run of reports:expire produces warnings

Added by Igor Galić almost 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Packaging
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

/usr/local/share/foreman/vendor/ruby/1.8/gems/ruby_parser-2.3.1/lib/ruby_parser_extras.rb:10: warning: already initialized constant ENC_NONE
/usr/local/share/foreman/vendor/ruby/1.8/gems/ruby_parser-2.3.1/lib/ruby_parser_extras.rb:11: warning: already initialized constant ENC_EUC
/usr/local/share/foreman/vendor/ruby/1.8/gems/ruby_parser-2.3.1/lib/ruby_parser_extras.rb:12: warning: already initialized constant ENC_SJIS
/usr/local/share/foreman/vendor/ruby/1.8/gems/ruby_parser-2.3.1/lib/ruby_parser_extras.rb:13: warning: already initialized constant ENC_UTF8

While this seems innocuous at first, when running this from cron in an environment of hundreds and hundreds of servers it can become noisy, desensitise and most importantly drown out when there's a real issue, because people just start ignoring everything that comes from that server


Related issues

Related to Foreman - Refactor #11059: Delete lib/regexp_extensions.rbClosed2015-07-09

Associated revisions

Revision c09b1dfe (diff)
Added by Dominic Cleal almost 7 years ago

fixes #2217 - initialize Regexp constants here to stop duplicate warnings

History

#1 Updated by Dominic Cleal almost 7 years ago

  • Status changed from New to Closed

This is a bug in the older ruby_parser gem we use, it's been fixed in ruby_parser 3.x which is in Foreman 1.1. We're also redirecting cron output to a log in future packages which should help.

#2 Updated by Dominic Cleal almost 7 years ago

  • Category set to Packaging
  • Status changed from Closed to Assigned
  • Assignee set to Dominic Cleal
  • Target version set to 1.2.0

Re-opening as we need to revert to the older ruby_parser again due to #2100.

#3 Updated by Dominic Cleal almost 7 years ago

  • Status changed from Assigned to Ready For Testing

#4 Updated by Dominic Cleal almost 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal over 4 years ago

Also available in: Atom PDF