Bug #22205

Notifications actions are not correctly set if they are based on blueprint

Added by Marek Hulán 6 months ago. Updated 9 days ago.

Status:Closed
Priority:Normal
Assignee:Marek Hulán
Category:Notifications
Target version:1.17.0
Difficulty: Team Backlog:
Triaged: Fixed in Releases:
Bugzilla link: Found in Releases:
Pull request:https://github.com/theforeman/foreman/pull/5159

Description

After RSS notification was added, blueprint actions stopped working. The reason is that notification actions defaults to {} and the code that sets default actions from blueprint does ||= which never overrides empty hash. We need to change the condition to if self.actions.blank?

Since this is a regression in 1.17 and easy fix, marking as 1.17 blocker, please reset if you disagree.


Related issues

Related to Foreman - Feature #18292: Add notifications for an RSS feed Closed 01/27/2017

Associated revisions

Revision 099d4ea9
Added by Marek Hulán 6 months ago

Fixes #22205 - restore blueprint actions for notifications

History

#1 Updated by The Foreman Bot 6 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5159 added

#2 Updated by Marek Hulán 6 months ago

#3 Updated by Marek Hulán 6 months ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF