Project

General

Profile

Bug #22205

Notifications actions are not correctly set if they are based on blueprint

Added by Marek Hulán almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Notifications
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

After RSS notification was added, blueprint actions stopped working. The reason is that notification actions defaults to {} and the code that sets default actions from blueprint does ||= which never overrides empty hash. We need to change the condition to if self.actions.blank?

Since this is a regression in 1.17 and easy fix, marking as 1.17 blocker, please reset if you disagree.


Related issues

Related to Foreman - Feature #18292: Add notifications for an RSS feed Closed

Associated revisions

Revision 099d4ea9 (diff)
Added by Marek Hulán almost 3 years ago

Fixes #22205 - restore blueprint actions for notifications

History

#1 Updated by The Foreman Bot almost 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5159 added

#2 Updated by Marek Hulán almost 3 years ago

#3 Updated by Marek Hulán almost 3 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF