Project

General

Profile

Actions

Bug #22205

closed

Notifications actions are not correctly set if they are based on blueprint

Added by Marek Hulán almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Notifications
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

After RSS notification was added, blueprint actions stopped working. The reason is that notification actions defaults to {} and the code that sets default actions from blueprint does ||= which never overrides empty hash. We need to change the condition to if self.actions.blank?

Since this is a regression in 1.17 and easy fix, marking as 1.17 blocker, please reset if you disagree.


Related issues 1 (0 open1 closed)

Related to Foreman - Feature #18292: Add notifications for an RSS feed ClosedDaniel Lobato GarciaActions
Actions

Also available in: Atom PDF