Project

General

Profile

Feature #22253

Extend option validators to validate resolved options

Added by Martin Bacovsky over 1 year ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
Hammer core
Target version:
-
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Implementation idea would be:
- validation object instead of block
- possibility to use it during option collecting in selected order
- get partially collected options as an input

Associated revisions

Revision 23707d1f (diff)
Added by Tomas Strachota 7 months ago

Fixes #22253 - Option validators can be mixed with sources

Revision 12fc9d63 (diff)
Added by Tomas Strachota 7 months ago

Refs #22253 - Allow mixing option sources and validations (#402)

  • Refs #22253 - Allow mixing option sources and validations

History

#1 Updated by Martin Bacovsky over 1 year ago

  • Category set to Hammer core

#3 Updated by Tomáš Strachota over 1 year ago

I'll add a few comments:
  • Validation objects should be kept in the same array as option sources to enable mixing them and validating some options before a certain option source is executed.
  • The current 'validate_options' block should be silently translated to a validation object to keep backward compatibility while being consistent in how we do validations.

#4 Updated by Tomáš Strachota 8 months ago

  • Assignee set to Tomáš Strachota
  • Status changed from New to Assigned

#5 Updated by The Foreman Bot 8 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli/pull/242 added

#6 Updated by The Foreman Bot 7 months ago

  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/402 added

#7 Updated by Anonymous 7 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF