Project

General

Profile

Bug #22259

Libvirt hostdev network breaks entire compute resource

Added by Vyacheslav Spiridonov over 3 years ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Compute resources - libvirt
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Hi all!

There is an old bug in library fog-libvirt, which is used by foreman to get information about libvirt networks: https://github.com/fog/fog-libvirt/issues/24

If there is a network without "bridge" parameter present, e.g. pool of virtual functions on NIC - almost every operation on this compute resource throws an error:

Call to virNetworkGetBridgeName failed: internal error: network 'libvirt-network-name' does not have a bridge name.

I cannot create any VM or import existing VMs.

I believe such networks are not supported by Foreman.
But maybe it's possible to handle such error and ignore this network. So user will be able to work with this compute resource using other networks.

Best regards,
Vyacheslav Spiridonov

Associated revisions

Revision 37a0c481 (diff)
Added by Marek Hulán 6 months ago

Fixes #22259 - bump fog-libvirt

History

#1 Updated by Marek Hulán 8 months ago

The fix really needs to go to fog-libvirt. If we add rescue, we won't load any network and the compute resource would be basically unsuable anyway. We only load all network at once, which fails on fog-libvirt side. It seems it can be easily fixed in fog-libvirt though, so I'm opening a PR there - https://github.com/fog/fog-libvirt/pull/78. If it's accepted, we just need to bump fog-libvirt dependency in Foreman.

#2 Updated by Marek Hulán 7 months ago

PR is merged, waiting on fog-libvirt release so we can bump it on our end

#3 Updated by The Foreman Bot 6 months ago

  • Assignee set to Marek Hulán
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8278 added

#4 Updated by The Foreman Bot 6 months ago

  • Fixed in Releases 2.4.0 added

#5 Updated by Marek Hulán 6 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF