Bug #223
closed
When a host update has errors then the render :edit loses required variables
Description
Scenario
The user is editing a pre-existing host. The user presses update. The record fails validation.
Instead of redirect_to @host we render :action => :edit
The Hostscontroller#edit method sets three variables which are used in the render :action => edit operation. These are not set when rendering from another method.
Files
Updated by Paul Kelly over 14 years ago
- File 0001-Fixes-223.patch 0001-Fixes-223.patch added
- Status changed from New to Ready For Testing
All variables were replaced by their original fully qualified method path from the host object, in the supplied patch file
Updated by Ohad Levy over 14 years ago
this patch doesn't remove the instance varibles which are set (e.g. @environment, @operatingsystem etc)
Updated by Paul Kelly over 14 years ago
I tried sending the patch as an email, Maybe that as the problem. If I run git log -p
diff --git a/app/controllers/hosts_controller.rb b/app/controllers/hosts_controller.rb
index 6a20117..9630d7d 100644
--- a/app/controllers/hosts_controller.rb
+++ b/app/controllers/hosts_controller.rb
@@ -51,9 +51,6 @@ class HostsController < ApplicationController
def edit
@host = Host.find(params[:id])
- @environment = @host.environment
- @architecture = @host.architecture
- @operatingsystem = @host.operatingsystem
end
Updated by Ohad Levy over 14 years ago
- Target version set to 0.1-5
what do you think of passing the parameters once redirecting to edit?, e.g.
def edit @host = .. @environment = params[:environment_id] || @host.environment ..
Updated by Ohad Levy over 14 years ago
- Status changed from Ready For Testing to Assigned
- Assignee changed from Paul Kelly to Ohad Levy
Updated by Ohad Levy over 14 years ago
- Status changed from Assigned to Ready For Testing
- % Done changed from 0 to 100
Applied in changeset 003ae9a1e2f1af661673cf5b2db6da8f126fc998.
Updated by Ohad Levy over 14 years ago
- Status changed from Ready For Testing to Closed