Project

General

Profile

Bug #22352

Satellite 6.3 foreman-templates plugin, API/UI template_sync_prefix has blank space stripped when updated

Added by Lukas Zapletal over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1493295

Description of problem:

When using the UI or API, the template_sync_prefix has it's value blank space stripped before persistence. The plugin has configured with the value "community " - notice the space at the end.

This allows templates that are imported to have the following pattern:

community kickstart template
community finishing template
community kickstart PXELinux template

However, upon update with a new prefix (ex: "Company "), the blank space is stripped, and now it looks like this upon import:

Companykickstart template
Companyfinishing template
Comapnykickstart PXELinux template

Further, in the UI, it appears the blank space is visible, until you reload the page, then you see the persistence layer has stripped the blank space.

Version-Release number of selected component (if applicable):

tfm-rubygem-foreman_templates-5.0.1-1.fm1_15.el7sat.noarch

How reproducible:

Steps to Reproduce:
1. Update template_sync_prefix setting via hammer
2. Update template_sync_prefix via API
3. Update template_sync_prefix via UI

Actual results:

Value has it's blank space stripped.

Expected results:

Blank space is preserved.

Additional info:

[root@sat1 foreman-templates]# ./2_prefix_bug
+ hammer settings set --name template_sync_prefix --value 'Local '
Setting [template_sync_prefix] updated to [Local]
+ curl -s --user admin:******** 'https://sat1.example.com/api/settings?search=name=template_sync_prefix'
+ jq '{results}[][0].id'
+ id=168
+ data='{"value": "Local "}'
+ curl -s --user admin:******** https://sat1.example.com/api/settings/168 -X PUT -d '{"value": "Local "}' -H content-type:application/json
+ jq .value
"Local"


Related issues

Related to Foreman - Feature #22355: Make stripping setting value optionalClosed2018-01-22

Associated revisions

Revision 3bd40906 (diff)
Added by Ondřej Pražák over 4 years ago

Fixes #22352 - Do not trim whitespace for prefix setting (#76)

History

#1 Updated by Ondřej Pražák over 4 years ago

  • Related to Feature #22355: Make stripping setting value optional added

#2 Updated by The Foreman Bot over 4 years ago

  • Assignee set to Ondřej Pražák
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_templates/pull/76 added

#3 Updated by Marek Hulán over 4 years ago

  • Legacy Backlogs Release (now unused) set to 264
  • Subject changed from Satellite 6.3 foreman-templates plugin, API/UI template_sync_prefix has blank space stripped when updated to Satellite 6.3 foreman-templates plugin, API/UI template_sync_prefix has blank space stripped when updated

#4 Updated by Anonymous over 4 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF