Project

General

Profile

Actions
Copy link

Refactor #22374

closed

Deduplicate the import logic

Added by Ondřej Pražák almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Marek Hulán
Target version:
foreman_templates 6.0.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman_templates/pull/77, https://github.com/theforeman/foreman_templates/pull/83, https://github.com/theforeman/foreman_templates/pull/84, https://github.com/theforeman/foreman_templates/pull/87
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Each template class has `import!` method implementation that handles how a specific template is imported. The method also takes care of message generation which are propagated to let user know whether a particular template was successfully imported or not. This leads to unnecessary duplication of code.

Actions
Copy link
 #1

Updated by The Foreman Bot over 6 years ago

  • Assignee set to Marek Hulán
  • Pull request https://github.com/theforeman/foreman_templates/pull/77 added
Actions
Copy link
 #2

Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
Actions
Copy link
 #3

Updated by Marek Hulán over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by The Foreman Bot over 6 years ago

  • Pull request https://github.com/theforeman/foreman_templates/pull/83 added
Actions
Copy link
 #5

Updated by Marek Hulán over 6 years ago

  • Translation missing: en.field_release set to 264
Actions
Copy link
 #6

Updated by The Foreman Bot over 6 years ago

  • Pull request https://github.com/theforeman/foreman_templates/pull/84 added
Actions
Copy link
 #7

Updated by The Foreman Bot over 6 years ago

  • Pull request https://github.com/theforeman/foreman_templates/pull/87 added
Actions
Copy link

Also available in: Atom PDF