Project

General

Profile

Feature #22454

VMware: Validate user data template is valid yaml

Added by Timo Goebel 7 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Compute resources - VMware
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

We should validate the user data template is valid yaml before sending it to fog-vsphere to avoid confusing error messages.

| NoMethodError: undefined method `key?' for false:FalseClass
| /opt/theforeman/tfm/root/usr/share/gems/gems/fog-vsphere-1.7.0/lib/fog/vsphere/requests/compute/cloudinit_to_customspec.rb:16:in `cloudinit_to_customspec'
| /usr/share/foreman/app/models/compute_resources/foreman/model/vmware.rb:487:in `clone_vm'
| /usr/share/foreman/app/models/compute_resources/foreman/model/vmware.rb:422:in `create_vm'
| /usr/share/foreman/app/models/concerns/orchestration/compute.rb:77:in `setCompute'
| /usr/share/foreman/app/models/concerns/orchestration.rb:216:in `execute'
| /usr/share/foreman/app/models/concerns/orchestration.rb:144:in `block in process'
| /usr/share/foreman/app/models/concerns/orchestration.rb:136:in `each'
| /usr/share/foreman/app/models/concerns/orchestration.rb:136:in `process'
| /usr/share/foreman/app/models/concerns/orchestration.rb:44:in `around_save_orchestration'

Associated revisions

Revision a31c09f5 (diff)
Added by Timo Goebel 7 months ago

fixes #22454 - vmware: validate user data for customspec

History

#1 Updated by The Foreman Bot 7 months ago

  • Assignee set to Timo Goebel
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5232 added

#2 Updated by Ivan Necas 7 months ago

  • Legacy Backlogs Release (now unused) set to 330
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF